Skip to content

Use -threaded for iserv-proxy #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

Use -threaded for iserv-proxy #2385

merged 3 commits into from
Jun 9, 2025

Conversation

@hamishmack
Copy link
Collaborator

@hamishmack hamishmack commented Jun 8, 2025

Fixes #2361

@luite tracked the failure down:

It's an async IO call that fails, async and fdwait have some limitations on Windows. the threaded runtime doesn't use them

hamishmack added 3 commits June 9, 2025 10:13
@hamishmack
Use -threaded for iserv-proxy
d2b9130 
Fixes #2361

@luite tracked the failure down:

> It's an async IO call that fails, async and fdwait have some limitations on Windows. the threaded runtime doesn't use them
@hamishmack
Disable threaded for aarch64 cross GHC 9.6.7
a9b1e52
@hamishmack
Fix typo
17a543e
@hamishmack hamishmack merged commit 0006048 into master Jun 9, 2025
2359 of 2362 checks passed
@thomasjm thomasjm mentioned this pull request Jun 10, 2025
Open
@thomasjm
Copy link
Contributor

thomasjm commented Jun 25, 2025 •
edited
Loading

This actually broke some aarch64 cross-compilation for me. For example, using GHC 9.12.2 and trying to build the aarch64-multiplatform version of the lsp-types package (from an x86_64-linux machine):

lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> [433 of 452] Compiling Language.LSP.Protocol.Internal.Method ( generated/Language/LSP/Protocol/Internal/Method.hs, dist/build/Language/LSP/Protocol/Internal/Method.o )
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> ---> Starting iserv-proxy-interpreter on port 5914
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> ---| iserv-proxy-interpreter should have started on 5914
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> [434 of 452] Compiling Language.LSP.Protocol.Message.Method ( src/Language/LSP/Protocol/Message/Method.hs, dist/build/Language/LSP/Protocol/Message/Method.o )
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> Listening on port 5914
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> qemu: uncaught target signal 4 (Illegal instruction) - core dumped
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> iserv-proxy: Uncaught exception ghc-internal:GHC.Internal.IO.Exception.IOException:
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> {handle: <socket: 15>}: GHCi.Message.remoteCall: end of file
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> HasCallStack backtrace:
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu>   collectBacktraces, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:169:13 in ghc-internal:GHC.Internal.Exception
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu>   toExceptionWithBacktrace, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:89:42 in ghc-internal:GHC.Internal.Exception
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu>   throw, called at libraries/ghci/GHCi/Message.hs:673:16 in ghci-9.12.2-inplace:GHCi.Message
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> /nix/store/vv44dyf6yar3kyshnpmf2xz71mz44kgv-iserv-wrapper/bin/iserv-wrapper: line 13:  1412 Illegal instruction     /nix/store/j2crk2gim81vrbhjmxqz5hp43km15hn4-qemu-9.1.3/bin/qemu-aarch64 /nix/store/vqy85983mrhp7wjgcr2p
fzrvpxzw879c-iserv-proxy-exe-iserv-proxy-interpreter-aarch64-unknown-linux-gnu-9.3/bin/iserv-proxy-interpreter tmp $PORT $ISERV_ARGS
lsp-types-lib-lsp-types-aarch64-unknown-linux-gnu> <no location info>: error: External interpreter terminated (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression when reading files via TH in windows (ucrt64) cross compilation on GHC 9.6/9.8/9.10

3 participants

@hamishmack @thomasjm